Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update __main__.py #14

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

j-b-d
Copy link
Contributor

@j-b-d j-b-d commented Feb 22, 2022

with the lately accepted pull request that opened the door for more recent pyyaml-versions the loader should be specified when loading a license override file (at least in our pipelines this suddenly lead to fails [and safe loader should be ok since there are just some strings being loaded and no complex data structures])

image

@initialed85
Copy link
Contributor

Ah interesting- nice find. Sorry for the delay in responding, I'll do a quick bit of testing and then do another release.

Sorry it broke your builds!

Copy link
Contributor

@initialed85 initialed85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

EDIT: Has been released + uploaded to PyPI

@@ -131,7 +131,7 @@
license_overrides = {}
if args.license_override_file is not None:
with codecs.open(args.license_override_file, "r", "utf-8") as f:
license_overrides = yaml.load(f.read())
license_overrides = yaml.load(f.read(), Loader=yaml.SafeLoader)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - thank you very much for this helpful package! 😊

@initialed85 initialed85 merged commit b5fe74b into ftpsolutions:master Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants