Skip to content

change the test to get the 'expected' version from the RELEASE_NOTES to ensure it stays in sync #4084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021
Merged

change the test to get the 'expected' version from the RELEASE_NOTES to ensure it stays in sync #4084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions tests/Paket.Tests/Packaging/PackageProcessSpecs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ open Paket
open FsUnit
open NUnit.Framework

let rec tryFindFileInHeirarchy (startDir: DirectoryInfo) (targetFileName: string): string option =
if isNull startDir then None
else
let testPath = Path.Combine(startDir.FullName, targetFileName)
if File.Exists testPath then Some (normalizePath testPath)
else tryFindFileInHeirarchy startDir.Parent targetFileName

[<Test>]
let ``Loading assembly metadata works``() =
// When debugging CurrentDirectory is C:\Windows\system32
Expand All @@ -19,35 +26,31 @@ let ``Loading assembly metadata works``() =
else curDir

use _cd = TestHelpers.changeWorkingDir workingDir
let workingDir = DirectoryInfo workingDir
let projectFilePath =
tryFindFileInHeirarchy workingDir "Paket.Tests.fsproj"
|> Option.defaultWith (fun _ -> failwithf "%s does not exist in the directory heirarchy of %s." "Paket.Tests.fsproj" workingDir.FullName)

let fileName =
if File.Exists(Path.Combine(workingDir, "Paket.Tests.fsproj")) then
Path.Combine(workingDir, "Paket.Tests.fsproj")
|> normalizePath
elif File.Exists(Path.Combine(workingDir, "..", "..", "Paket.Tests.fsproj")) then
Path.Combine(workingDir, "..", "..", "Paket.Tests.fsproj")
|> normalizePath
else
Path.Combine(workingDir, "..", "..", "..", "Paket.Tests.fsproj")
|> normalizePath

if File.Exists fileName |> not then
failwithf "%s does not exist." fileName

let projFile =
fileName
let projFile =
projectFilePath
|> ProjectFile.LoadFromFile

let config =
if workingDir.Contains "Debug" then "Debug"
let config =
if workingDir.FullName.Contains "Debug" then "Debug"
elif assemblyLocation.Contains "Debug" then "Debug"
else "Release"

let assemblyReader,id,versionFromAssembly,fileName = PackageMetaData.readAssemblyFromProjFile config "" projFile

let paketReleaseNotesVersion =
tryFindFileInHeirarchy workingDir "RELEASE_NOTES.md"
|> Option.map (File.ReadLines >> Seq.head)
|> Option.map (fun line -> line.Split(' ').[1]) // format is ### <VERSION> - <DATE>, so taking second element of array is the version
|> Option.defaultWith (fun _ -> failwithf "unable to parse current version from RELEASE_NOTES.md in the directory heirarchy of %s" workingDir.FullName)

let assemblyReader, id, versionFromAssembly, _fileName = PackageMetaData.readAssemblyFromProjFile config "" projFile
id |> shouldEqual "Paket.Tests"

let attribs = PackageMetaData.loadAssemblyAttributes assemblyReader
PackageMetaData.getVersion versionFromAssembly attribs |> shouldEqual <| Some(SemVer.Parse "1.0.0.0")
PackageMetaData.getVersion versionFromAssembly attribs |> shouldEqual <| Some(SemVer.Parse paketReleaseNotesVersion)
let authors = PackageMetaData.getAuthors attribs
authors.Value |> shouldEqual ["Two"; "Authors" ]
PackageMetaData.getDescription attribs |> shouldEqual <| Some("A description")
3 changes: 1 addition & 2 deletions tests/Paket.Tests/Paket.Tests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
<OutputType>Library</OutputType>
<TargetFrameworks>net461;netcoreapp3.1</TargetFrameworks>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<!-- these three properties are set for some tests around assembly metadata parsing.
<!-- these two properties are set for some tests around assembly metadata parsing.
they're written to the generated AssemblyInfo.fs -->
<Version>1.0.0</Version>
<Authors>Two,Authors</Authors>
<Description>A description</Description>
</PropertyGroup>
Expand Down