Use a different nuget extraction routine to extract to versioned folders

[baronfel]

Fixes #4075 by using nuget APIs for extraction to versioned folders directly. I also integrated logging from nuget into our logging, but behind the verboseFn safeguards so as to not spam users.

[baronfel]

definitely looks like there's some amount of lock contention happening as a result of this now, based on the test failures.

[baronfel]

cool, the only failing test is the same one that's failing in #4080, so if I can figure that out then we should be good to go.

[baronfel]

@smoothdeveloper do you have any ideas what might be causing the issue in this test recently?

[smoothdeveloper]

@baronfel, no idea

https://github.com/fsprojects/Paket/blob/b2feccc8f9e49f731083d2e2bfc5f47e5328eaa8/integrationtests/Paket.IntegrationTests/FsiExtension.fs

  Error Message:
   file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithBrokenDepsFile\plot.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithBrokenDepsFile\plot.fsx
file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithDepsCanHaveGroups\plot.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithDepsCanHaveGroups\plot.fsx
file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithLocalSources\script1.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithLocalSources\script1.fsx
file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithRemoteFile\UseGlobbing.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithRemoteFile\UseGlobbing.fsx
file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTest\fsharp.data.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTest\fsharp.data.fsx
file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTest\plot.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTest\plot.fsx
file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTestTrim\plot.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTestTrim\plot.fsx
file: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\transitiveloadscripts\b.fsx
command: fsi --langversion:preview --compilertool:C:\projects\paket\integrationtests\Paket.IntegrationTests\..\..\src\FSharp.DependencyManager.Paket\bin\Release\netstandard2.0 C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\transitiveloadscripts\b.fsx
  Standard Output Messages:
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithBrokenDepsFile\plot.fsx
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithDepsCanHaveGroups\plot.fsx
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithLocalSources\script1.fsx
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\PaketWithRemoteFile\UseGlobbing.fsx
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTest\fsharp.data.fsx
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTest\plot.fsx
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\SimplePaketTestTrim\plot.fsx
 KO: C:\projects\paket\integrationtests\scenarios\fsi-depmanager\deterministic.output\transitiveloadscripts\b.fsx

If you don't mind checking how it behaves locally, if it passes locally, I guess adjusting the print statement to output the expected and actual output will give us an indication on what's wrong on the integration machine.

[forki]

what's the status here?

[baronfel]

Blocked by a failing test in the FSI handler, but this same test is failing in master as well so I'm not sure it's because of these changes.