Skip to content

Corrects memozation of HttpHandlers. #3881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2020
Merged

Corrects memozation of HttpHandlers. #3881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Paket.Core/Common/NetUtils.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,13 @@ let createHttpHandlerRaw(url, auth: Auth option) : HttpMessageHandler =
handler :> _


let createHttpHandler = memoize createHttpHandlerRaw
let createHttpHandler =
memoizeBy
// Truncates the url to only to host part, so there is only one handler per source/host.
// 8 chars as startindex is chosen because `https://` is 8 chars long and we need the host delimiting `/`.
// For instance `https://api.nuget.org/v3/index.json` and `https://api.nuget.org/v3-flatcontainer/fsharp.core/index.json?semVerLevel=2.0.0` both get truncated to `https://api.nuget.org/` and share one handler (and one connection pool).
(fun (url : string, auth) -> url.Substring(0, url.IndexOf('/', 8) + 1), auth)
createHttpHandlerRaw

let createHttpClient (url,auth:Auth option) : HttpClient =
let handler = createHttpHandler (url, auth)
Expand Down