Adding parsing logic for protocolVersion on source#3844

Merged

forki merged 24 commits intofsprojects:bugfixfrom

tebeco:explicit-protocol-version-on-source

Jun 14, 2020

Commits on May 26, 2020

Naivly handling NugetConvert to default all sources to ProtcolVersion 3
tebeco
committed
adding NugetProtocolVersion to ParseState to that parsing the LockFile could "materialize" back the protocolVersion
tebeco
committed
Res-use Source.Parse logic with the given ProtocolVersion from "currentGroup.NugetProtocolVersion"
tebeco
committed
typo (better bane for that function ?)
tebeco
committed
default NugetProtocolVersion to None
tebeco
committed
Add NugetProtocolVersion member to the existing NuGetSource
tebeco
committed
NEED REVIEW/HELP: uses protocolVersion in the "GroupBy" key to be able to get it back later to be able to emit it before listing packages
tebeco
committed
NEED REVIEW/HELP: Emitting the protocolVersion in lockfile <= Magic string definitly looks bad
tebeco
committed
NEED REVIEW/HELP: Trying to add ProtocolVersion in the parsing code for LockFile
tebeco
committed
NEED REVIEW/HELP: Not sure if this is what i was supposed to do, I reused how does InstallOption(Command...) works
tebeco
committed
force ProtocolVersion2 for getSearchAPI as it's already using Url = v3Path
tebeco
committed
force ProtocolVersion2 for the fallback of "v3AndFallBack" after getting a new v2 url from calculateNuGet2Path
tebeco
committed
force ProtocolVersion2 for ParserSpecs NugetV2 tests
tebeco
committed
simplifying NugetProtocolVersion.ProtocolVersion2/3 to ProtocolVersion2/3
tebeco
committed
Not sure the "protocolVersion" was intended to be here in the first place
tebeco
committed
update test baselines with protocolVersion where appropriate

baronfel
authored and
tebeco
committed
remove nugetv2/nugetv3 types in favor of matching on protocol

baronfel
authored and
tebeco
committed
change defaults to protocol version 2

baronfel
authored and
tebeco
committed
derive common url protocols + don't emit protocol for local sources

baronfel
authored and
tebeco
committed
fix ordering of match statements so nuget source is parsed

baronfel
authored and
tebeco
committed
use explicit space in regex instead of \s which would be doing something completly different here
tebeco
committed
Adding test to check that even enforcing protocolVersion on known source respect the explicit the specified protocolVersion (this will probably raise error during install/restore but it will be "lo…
tebeco
committed
Add .\Versioning\PackageSourceSpecs.fs to /tests/Paket.Tests.preview3/Paket.Tests.fsproj to be able to debug on bugfix branch
tebeco
committed
Adding test for invalid protocolVersion (missing / letter / space / out of range)
tebeco
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adding parsing logic for protocolVersion on source#3844

Adding parsing logic for protocolVersion on source#3844
forki merged 24 commits intofsprojects:bugfixfrom
tebeco:explicit-protocol-version-on-source

Commits on May 26, 2020

Naivly handling NugetConvert to default all sources to ProtcolVersion 3

adding NugetProtocolVersion to ParseState to that parsing the LockFile could "materialize" back the protocolVersion

Res-use Source.Parse logic with the given ProtocolVersion from "currentGroup.NugetProtocolVersion"

typo (better bane for that function ?)

default NugetProtocolVersion to None

Add NugetProtocolVersion member to the existing NuGetSource

NEED REVIEW/HELP: uses protocolVersion in the "GroupBy" key to be able to get it back later to be able to emit it before listing packages

NEED REVIEW/HELP: Emitting the protocolVersion in lockfile <= Magic string definitly looks bad

NEED REVIEW/HELP: Trying to add ProtocolVersion in the parsing code for LockFile

NEED REVIEW/HELP: Not sure if this is what i was supposed to do, I reused how does InstallOption(Command...) works

force ProtocolVersion2 for getSearchAPI as it's already using Url = v3Path

force ProtocolVersion2 for the fallback of "v3AndFallBack" after getting a new v2 url from calculateNuGet2Path

force ProtocolVersion2 for ParserSpecs NugetV2 tests

simplifying NugetProtocolVersion.ProtocolVersion2/3 to ProtocolVersion2/3

Not sure the "protocolVersion" was intended to be here in the first place

update test baselines with protocolVersion where appropriate

remove nugetv2/nugetv3 types in favor of matching on protocol

change defaults to protocol version 2

derive common url protocols + don't emit protocol for local sources

fix ordering of match statements so nuget source is parsed

use explicit space in regex instead of \s which would be doing something completly different here

Adding test to check that even enforcing protocolVersion on known source respect the explicit the specified protocolVersion (this will probably raise error during install/restore but it will be "lo…

Add .\Versioning\PackageSourceSpecs.fs to /tests/Paket.Tests.preview3/Paket.Tests.fsproj to be able to debug on bugfix branch

Adding test for invalid protocolVersion (missing / letter / space / out of range)

Adding parsing logic for protocolVersion on source#3844forki merged 24 commits intofsprojects:bugfixfsprojects/Paket:bugfixfrom tebeco:explicit-protocol-version-on-sourceCopy head branch name to clipboard

Commits

Commits on May 26, 2020

Adding parsing logic for protocolVersion on source#3844
forki merged 24 commits intofsprojects:bugfixfrom
tebeco:explicit-protocol-version-on-source