#2419. Try parse SemVerInfo from .nupkg file name for localFolder nuget source #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
wow this looks very good! |
forki
approved these changes
Jun 15, 2017
| @@ -41,16 +52,18 @@ let findLocalPackage directory (packageName:PackageName) (version:SemVerInfo) = | |||
| let v2 = FileInfo(Path.Combine(directory, sprintf "%O.%s.nupkg" packageName normalizedVersion)) | |||
| if v2.Exists then v2 else | |||
|
|
|||
| let condition x = | |||
| match parsePackageInfoFromFileName x with | |||
| | Some (name, ver) -> packageName.Equals name && version.Equals ver | |||
There was a problem hiding this comment.
Why not | Some (name, ver) -> packageName = name && version = ver?
| ("package.name.with.dots.1.2.3-alpha2.nupkg", Some (PackageName "package.name.with.dots", SemVer.Parse "1.2.3-alpha2")); | ||
| ("package.1.2.3.nupkg.back", None); | ||
| ("package.name.without.version.nupkg", None); | ||
| ] |
There was a problem hiding this comment.
[
"package.1.2.3.nupkg", Some (PackageName "package", SemVer.Parse "1.2.3")
"package.1.2.3-alpha2.nupkg", Some (PackageName "package", SemVer.Parse "1.2.3-alpha2")
"package.name.with.dots.1.2.3-alpha2.nupkg", Some (PackageName "package.name.with.dots", SemVer.Parse "1.2.3-alpha2")
"package.1.2.3.nupkg.back", None
"package.name.without.version.nupkg", None
]
| [<Test>] | ||
| let ``package file picked up correctly``() = | ||
| [ // folder * inputPackageId * inputPackageVersion * expectedFileName | ||
| "./NuGetLocal/case1", PackageName "package.name", SemVer.Parse "0.1.0-alpha2", "package.name.0.1.0-alpha2.nupkg"; |
There was a problem hiding this comment.
Unnecessary semicolons.
There was a problem hiding this comment.
thank you, fix all three places
|
travis failures seem unrelated. |
|
For the travis failure we will soon have #2423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2419