github dependency fails to download

[enricosada]

-> Could not download from 'https://raw.githubusercontent.com/enricosada/add_icon_to_exe/e11eda501acea369ac2950beb34b8888495bf21f/rh/ResourceHacker.exe'
-> FileNotFoundException: Could not load file or assembly 'System.Net.Http.WinHttpHandler, Version=4.0.3.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.

[JohnyWS]

Any progess? Not sure how I can help out here? :-/

[JohnyWS]

Hmm, the issue appears to be resolved now? What has been changed? @matthid / @forki ? :)

[forki]

It's not resolved. @enricosada I assume we need to ilmerge the lib into the net46x exe, right? Johny Woller Skovdal <notifications@github.com> schrieb am Di., 3. Dez. 2019, 08:12:

…

Hmm, the issue appears to be resolved now? What has been changed? @matthid <https://github.com/matthid> / @forki <https://github.com/forki> ? :) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3738?email_source=notifications&email_token=AAAOANE55N7KVVU3E7XUQ2LQWYBG3A5CNFSM4JTVOTQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFYLATI#issuecomment-561033293>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOANEAZSWJHN247OH4AWLQWYBG3ANCNFSM4JTVOTQQ> .

[enricosada]

Yes, that’s my guess too. I tried yesterday but failed.
I’ll retry later today

[JohnyWS]

Hmm, but github update does not fail for me today? It did last night. Has the release page been updated, or why am I not experiencing any errors today if the error isn't resolved?

[forki]

@JohnyWS I assume you tested with 5.x

[enricosada]

I tried the exact same ilmerge change but didn’t work for me.
Dunno

[forki]

whate exactly did not work? ILRepack failed or did the resulting exe not work?

[enricosada]

Ilmerge ok, but the resulting exe didn’t fix the issue.
Maybe I did something wrong locally dunno, probably my bad, it’s the fix I expected too

[forki]

@enricosada it worked, but:

-> FileNotFoundException: Could not load file or assembly 'System.Buffers, Version=4.0.3.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. The system cannot find the file specified.

[forki]

ILMerging the second one helped. build is green. yay