-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: dotnet sdk and TPSDK updates for netstandard2.0 #91
base: master
Are you sure you want to change the base?
Conversation
…DK. Also pin FSharp.Core to 4.3.x because we don't want to take a dependency on F# 4.5 yet
Alright, I tested the generated nuget package from this in a local netcoreapp2.0/netstandard2.0 project, and it works! With the caveats listed in the table above this is ready to go in my opinion. |
@sergey-tihon @forki @vasily-kirichenko what would you all think about reviewing/merging this and then releasing a prerelease, like we've done for FSharp.Configuration and FSharp.Data? That would allow for wider testing on netcore platforms. I know that my workplace would like to begin testing of this. |
@baronfel Agree, let's publish it as I've tried to build it on macOS and on Win, it fails on both. Windows (dotnet 2.1.401)macOS (dotnet 2.1.401) |
This is as far as I've gotten with converting this repo to .net standard 2.0.
Some of these type providers in general will be very difficult if not impossible in their current forms to port over without significant further work.
I'm hoping to get to a point where the cross-platform compatible type providers can be compiled for net462 and netstandard2.0, and the windows-only type providers can be compiled just for net462, and then we can just package them all for their appropriate frameworks.
Future work then could take on the larger challenges of porting the windows-only TPs to netstandard where appropriate (powershell core for example).
Further steps