combinePaths with no trimming operations #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous versions of combinePath stripped of leading slashes from path2, which caused behaviors to be different between linux and windows. This new version of combinePaths doesn't trim the leading slashes, allowing the underlying Path.Combine to behave the same on both windows and linux. This fixes #670
forki
added a commit
that referenced
this pull request
Mar 12, 2015
combinePaths with no trimming operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of combinePath stripped of leading slashes from path2, which caused behaviors to be different between linux and windows. This new version of combinePaths doesn't trim the leading slashes, allowing the underlying Path.Combine to behave the same on both windows and linux. This fixes #670
We discussed several options for the operators. I managed to get just the plain / operator working using ideas mentioned here but in the end I decided to just use </> as the operator to do non trimmed path.combines.