Attempting to allow csproj being passed as a NuSpec file

[jamescrowley]

First crack at fixing #643

[forki]

Thanks for the fast pull request.

@ilkerde could you please verify that it also works for you?

[ilkerde]

@forki Thanks for letting me know. @jamescrowley Thanks for your fast contribution. I like your changes since the case of accompanying .nuspec is quite often.

However, I checked this PR and have to say that it breaks a test. After running CI I receive

Failures:
when packing with nuspec template
» should create nupkg file (FAIL)
System.Exception: Error during NuGet package creation. C:\Code\ilkerde.fake\test\TestData\nuget.exe pack -Version 0.0.1 -OutputDirectory "C:\Users\ilker.cetinkaya\AppData\Local\Temp" "fake.nuspec"

This is the test for NugetPack to be able to transform templates. Seems that your change breaks this. I suppose that you are changing something along the line of createNuspecFile, most probably the return value around L227. I would recommend to have tests for your case (nuspec alongside the csproj) as well.

Any chance to get this fixed (and probably even have a test for it)?

[forki]

@jamescrowley can I help you to get this in?

[jamescrowley]

@forki This still requires more work - the current code just tries to delete whatever file you pass in as an argument (https://github.com/jamescrowley/FAKE/blob/fix.NuGetPack/src/app/FakeLib/NuGet/NugetHelper.fs#L331).

[jamescrowley]

I think this at least works now @forki @ilkerde. it's ugly as anything, but has a test and will have to defer to others in terms of how we tidy up

[forki]

I think these files are gitignored. You need to add them "forced"

[jamescrowley]

https://bugzilla.xamarin.com/show_bug.cgi?id=17430 Hmm. Nice. So you can't actually nuget pack on a csproj file on mono. Thoughts @forki ?

[forki]

mhm. then maybe just use isMono function and throw a good exception.
In the test try to catch that exception in the mono case. does this sound OK?

BTW: we are actively working on http://fsprojects.github.io/Paket/paket-pack.html

[jamescrowley]

@forki I think I'd probably make the test check for isMono rather than the nuget helper? given we don't actually know whether nuget.exe in the future would support, and at least you get a decent error output when it fails ow?

[forki]

yes that's ok, too

[forki]

thanks for being so patient ;-)