Skip to content

Update the dotnet-install script URL in Fake.DotNet.getGenericDotNetCliInstallerUrl #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update the dotnet-install script URL in Fake.DotNet.getGenericDotNetCliInstallerUrl #2853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/Fake.DotNet.Cli/DotNet.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ module DotNet =
/// Get .NET Core SDK download uri
/// </summary>
let private getGenericDotNetCliInstallerUrl branch installerName =
sprintf "https://raw.githubusercontent.com/dotnet/cli/%s/scripts/obtain/%s" branch installerName
sprintf "https://raw.githubusercontent.com/dotnet/install-scripts/%s/src/%s" branch installerName
Copy link
Contributor Author

@Numpsy Numpsy Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really certain if this should be pulling the scripts from github or the 'distribution' urls such as https://dot.net/v1/dotnet-install.sh - but thats a bigger change which would mean dropping the configurable branch, so I just tried to keep it minimal for now

Copy link
Contributor

@richlander richlander Jan 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be sharing guidance shortly.

This issue should provide some insight: dotnet/install-scripts#558 (comment)


let private getPowershellDotNetCliInstallerUrl branch =
getGenericDotNetCliInstallerUrl branch "dotnet-install.ps1"
Expand Down Expand Up @@ -188,7 +188,7 @@ module DotNet =
/// Parameter default values.
static member Default =
{ AlwaysDownload = false
Branch = "master"
Branch = "main"
CustomDownloadDir = None }

/// <summary>
Expand Down
Loading