Allow RunSettingsArguments to be set
#2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheAngryByrd
force-pushed
the
2376-RunSettingsArguments
branch
from
8bd91a5
to
35ace1b
Compare
|
Don't think uploading failure in CI build is related to my changes |
xperiandri
approved these changes
Feb 6, 2024
xperiandri
force-pushed
the
2376-RunSettingsArguments
branch
from
35ace1b
to
1006bde
Compare
|
Could you add the line about this to the release notes? |
xperiandri
force-pushed
the
2376-RunSettingsArguments
branch
from
1006bde
to
d7505be
Compare
xperiandri
requested changes
Jul 15, 2024
TheAngryByrd
force-pushed
the
2376-RunSettingsArguments
branch
from
c1982da
to
51ec093
Compare
xperiandri
reviewed
Aug 6, 2024
Co-authored-by: Andrii Chebukin <[email protected]>
xperiandri
approved these changes
Aug 7, 2024
|
@TheAngryByrd could you rebase your changes or merge? |
|
You can also push to PR branches to fix them on minor stuff like this so you don't have to wait for the contributor to do it. |
|
OK, fixed |
xperiandri
changed the title
RunSettingsArguments to be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows
RunSettingsArgumentsto be set inDotNet.test. This is useful for configuring such as in YoloDev https://github.com/YoloDev/YoloDev.Expecto.TestSdk?tab=readme-ov-file#configurationIf available, link to an existing issue this PR fixes. For example:
TODO
Feel free to open the PR and ask for help
New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in
help/markdown)unit or integration test exists (or short reasoning why it doesn't make sense)
boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)
(if new module) the module has been linked from the "side navigation" menu, edit
docs/data.json.(if new module) the module is in the correct namespace.
(if new module) the module is added to Fake.sln (
dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)Fake API guideline is honored