-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 64 bit VS2022 path and version structure. #2631
Add support for 64 bit VS2022 path and version structure. #2631
Conversation
* next release * Fix sdk resolver for net6 assemblies. Using offical .NET release JSON to get runtime version (fsprojects#2625) * Fix sdk resolver for net6 assemblies. Using official .NET release JSON to get matching runtime version * Update RELEASE_NOTES.md
@isaacabraham no need to add the next version in Thanks |
@yazeedobaid Fixed, rerunning the build. |
@yazeedobaid can you re-run? Looks like the build failed because of a timeout. |
@isaacabraham I have re-run the build again and now it fails due to this error: Fsc: /home/runner/work/FAKE/FAKE/src/app/Fake.Sql.SqlPackage/Sql.SqlPackage.fs(201,22): error FS0001: All branches of an 'if' expression must return values of the same type as the first branch, which here is 'seq<string>'. This branch returns a value of type ''a list'. Thanks |
It seems I had introduced a conflict on this pull request when I merged the refactor of Thanks |
…upport # Conflicts: # RELEASE_NOTES.md
…2022-support # Conflicts: # src/app/Fake.Sql.SqlPackage/Sql.SqlPackage.fs
Hmm. I've merged and solved the conflict - that's not the issue, because it builds locally fine. I think the problem is that it's compiling against F#6 here but the build agent is still going against F#5: Despite having a global.json of .NET 6 preview (BTW, I think you should upgrade to a non-alpha version of .NET 6 e.g. 6.0.101), it's still using MSBuild 16. Maybe that's a red herring but it seems suspicious, and I can reproduce the exact compiler error by reverting back to building against .NET 5. |
@isaacabraham thanks for the update. Thanks |
Done |
Thanks |
Description
Fixes #2629 - now supports VS2022's installation of SqlPackage and gets the version using reflection against the executable itself.
TODO
I've tested this locally - my machine is a clean build that only has VS2022 on it, hence why I noticed this issue in the first place.