added: File.tryGetVersion #2379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses #2378
|
Additionally, we should change |
|
By the way don't worry about the build right now I have broken it in the release/next branch and trying to fix it... last good one is probably 64d5c19 in case you want to build locally. |
matthid
added
the
waiting for author
|
I would tend to a different exception, e.g. |
matthid
added a commit
that referenced
this pull request
Aug 25, 2019
- add tests - Change getVersion to not throw nullreferenceException, fixes #2378
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2378
At least if helps to avoid dealing with NullReferenceException