Fix high memory use and slowness with large number of targets/depende… #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 5.13.6
Release 5.13.7
Release 5.14.0
Release 5.14.1
Release 5.15.0
Release 5.15.1
Release 5.15.2
matthid
approved these changes
Jul 15, 2019
|
|
||
| // These dependencies are taken from large .NET/COM VS sln. Only the names have been changed. | ||
| // Printing the running order was taking 3 minutes and ~ 12 GB or RAM using FAKE 5.15 | ||
| Fake.ContextHelper.fakeContextTestCase "Running order resolves quickly when there are numerous targets with numerous dependencies" <| fun _ -> |
There was a problem hiding this comment.
Any reason not to use Fake.ContextHelper.fakeContextTestCaseAssertTime like in some tests above?
There was a problem hiding this comment.
No reason, just didn't know about it :)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ncies
Description
I built a fake script from a large Visual Studio solution. It worked well but took a long time and used many GB of memory before it printed out the build order. I have fixed the issue by making determineBuildOrder more efficient (was repeating a lot of work)
I added a unit test that is my solution with the project names replaced with random words.