-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homepage redesign #2164
Homepage redesign #2164
Conversation
Release 5.9.1
Release 5.9.2
Release 5.9.3
Thanks a lot, I owe you a drink ;). You are @forki Any objections to changing the icon to Lets see how it looks on staging :) |
Another question is whether we need some "quick" guide for the samples on the start page or tell people what to do with them (ie execute |
I don't think we need to do that. If the user really wants to get started, there is a big getting started button. The samples are just to give the user a feeling on how FAKE looks like and how easy it is. |
Looks very nice!
|
Ok can either of you send another pr on release/next? I might eventually but I think that's better than reverting and we can test on staging.fake.build until we are ready. The only downside is that I cannot (easily) release until we are ready :) And I noticed one minor thing as well: some code boxes are properly sized on mobile and some are not |
(regarding the boxes: it's not a blocker because I think it is better than today actually ;)) |
I just looked at the new site here at my working computer and everything is fine even in firefox. I can not reproduce the problem here, so that was maybe just some strange edge case. |
If put inside |
Mobile looks really quite odd... Default mobile resolution includes horizontal scroll, when zoom out to fit main content, the banners top and bottom are too narrow. Also, when menu expands it doesn't fill screen, so you end up with 2 scrollable windows... I tried to capture in a video, but can't seem to upload it.. |
Ok I think I found the issue with the code-block alignment, removed some stuff |
PrismJS and containers with margins don't work well together. I added a workaround for mobile devices. @matthid Can you give me permission to push to the website_updates branch so I can add my fixes or should I create a new pull request to that branch? |
@florianbader Please feel free to just send a PR to Looking at the clock I might have to continue tomorrow ;) From a bit of debugging it seems like we can remove everything in |
Description
This PR changes the design and layout of the current FAKE homepage. The idea was to make it simpler and more beginner friendly.
I added some of the changes as GIFs, so you don't have to build to take a look at it.
The new index page is missing most of the clutter from the current website and is now focused on the current version of FAKE and also has some samples for new users.
The new navigation is fixed to the top and the height was reduced to a minimum. The left side of the navigation features all important topics of the current version of FAKE while the right side is for API references and everything regarding FAKE 4. It also includes the social media links, so visitors can jump to them quickly.
For the tutorials and API references the pages now include a table of content side navigation which is generated on the fly. This makes it more easy jump to where you want to go.
If you miss some of the FAKE 4 alerts in the FAKE 5 documentation, I also got rid of them, because who cares about FAKE 4.
The website is still mobile-friendly (except for the API pages maybe, but they were broken on the current site too).
Additionally to the clutter I got rid of on the homepage, I also removed lots of code and files which were no longer needed and which should make it easier to maintain.
I also created a new FAKE logo, which is used as the brand icon in the navigation. Tell me what you think about it.
As for the frameworks behind the new design: It now uses Bulma as CSS framework and it uses Prism for the code formatting on the index page.
This PR addresses the issues mentioned in #2040.
TODO
The new website uses some custom JavaScript and CSS which is not minified yet and also uses CSS instead of SASS. It works for now but in the future, we might want to add something for this to the build file.