Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FSI evaluation option for FSharp.Formatting. #2158

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Allow FSI evaluation option for FSharp.Formatting. #2158

merged 1 commit into from
Oct 10, 2019

Conversation

kurtschelfthout
Copy link
Contributor

Description

Add an option to do FSI evaluation to FAKE wrapper for FSharp.Formatting command-line tool.

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • [] unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • [] (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.

  • [] (if new module) the module is in the correct namespace

  • [] (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake 5 API guideline is honored

@matthid
Copy link
Member

matthid commented Oct 14, 2018

Adding new tests, similar to #2133 (note the switch to the CreateProcess API to be more testable) would be appreciated.

@matthid matthid added the needs-tests This PR needs tests in order to be accepted label Oct 18, 2018
@jackfoxy
Copy link
Contributor

jackfoxy commented Nov 4, 2018

I have a use for this. I hope it can move forward.

@matthid matthid added the waiting for author Some information or action was requested and it needs to be addressed. Or a response from author label Nov 14, 2018
@matthid
Copy link
Member

matthid commented Nov 18, 2018

any interest in finishing this?

@jackfoxy
Copy link
Contributor

jackfoxy commented Nov 18, 2018

@matthid is this just waiting on tests?
@kurtschelfthout

@matthid
Copy link
Member

matthid commented Nov 18, 2018

indeed

@jackfoxy
Copy link
Contributor

I may be able to get to this in a couple weeks. (But I have no idea about what is involved.) I publicized this on twitter https://twitter.com/foxyjackfox/status/1064271460473090048

@matthid matthid merged commit c73e836 into fsprojects:release/next Oct 10, 2019
@matthid matthid mentioned this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-tests This PR needs tests in order to be accepted waiting for author Some information or action was requested and it needs to be addressed. Or a response from author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants