Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extended commit message #2038

Merged

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented Jul 26, 2018

Description

Git allows the user to specify two -m flags, where the first is sort of an issue summary, and the second has the longer, detailed message. I added support for this because I'd like to use it in our pipelines at work 😄

My only outstanding question is that the api guidelines suggest that modules have RequireQualifiedAccess and we don't have that on the Fake.Tools.Git.Commit module. Would you like me to add it?

TODO

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)
  • Fake 5 API guideline is honored

@matthid
Copy link
Member

matthid commented Jul 28, 2018

Would you like me to add it?

Sadly, the module hasn't been ported properly. Now that we have released our options are limited. Also Fake.Tools.Git is a namespace and not a module so that is already broken as you should open Fake.Toolsand notopen Fake.Tools.Git`. I guess we have to live with that now (or mark it obsolete and migrate to a new package).

@matthid
Copy link
Member

matthid commented Jul 28, 2018

Thanks!

@matthid matthid merged commit a3f35fa into fsprojects:release/next Jul 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants