Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Update #1906

Merged
merged 1 commit into from
May 4, 2018
Merged

Docs Update #1906

merged 1 commit into from
May 4, 2018

Conversation

vanceism7
Copy link
Contributor

Added some notes in the contributing.md about testing local module builds in fake scripts

matthid
matthid approved these changes May 4, 2018
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that should work, thanks for the idea!

@matthid matthid changed the base branch from master to rc_11 May 4, 2018 23:03
@matthid matthid merged commit 72df3f0 into fsprojects:rc_11 May 4, 2018
@matthid matthid mentioned this pull request May 6, 2018
Merged
@vanceism7 vanceism7 deleted the DocsUpdate branch May 11, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vanceism7 @matthid