Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for #1824 -- Nuget restore verbosity #1904

Merged
merged 3 commits into from
May 4, 2018

Conversation

vanceism7
Copy link
Contributor

I added in some helper functions just to make the argument passing a little easier and less error prone. Also, there's now two "duplicate" discriminated unions for Nugets verbosity arg. Should we make a file to hold common types for these? Lastly, I don't know if this needs any tests added or not. If there's anything I need to change, let me know!

@matthid
Copy link
Member

matthid commented May 4, 2018

Yes looks reasonable to me, thanks!

@matthid matthid changed the base branch from master to rc_11 May 4, 2018 22:55
@matthid
Copy link
Member

matthid commented May 4, 2018

giphy

@matthid matthid merged commit 524cf86 into fsprojects:rc_11 May 4, 2018
@matthid matthid mentioned this pull request May 6, 2018
@vanceism7 vanceism7 deleted the NugetRestoreVerbosity branch May 11, 2018 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants