Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAKE5 HockeyApp port #1870

Merged
merged 5 commits into from
Apr 15, 2018
Merged

FAKE5 HockeyApp port #1870

merged 5 commits into from
Apr 15, 2018

Conversation

MrLuje
Copy link
Contributor

@MrLuje MrLuje commented Apr 14, 2018

No description provided.

matthid
matthid approved these changes Apr 14, 2018
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. Only one minor thing.

src/app/Fake.Api.HockeyApp/HockeyApp.fs Outdated

/// The HockeyAppVersion parameter type
/// Based on https://support.hockeyapp.net/kb/api/api-versions#create-version
[<CLIMutable>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need CLIMutable anymore

src/app/Fake.Api.HockeyApp/HockeyApp.fs Outdated

/// The HockeyApp parameter type
/// Based on http://support.hockeyapp.net/kb/api/api-apps#upload-app
[<CLIMutable>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

@matthid matthid changed the base branch from master to rc_5 April 15, 2018 13:59
@matthid
Copy link
Member

matthid commented Apr 15, 2018

Thanks

@matthid matthid merged commit 2fdb43f into fsprojects:rc_5 Apr 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrLuje @matthid