Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert YarnHelper to module #1868

Merged
merged 1 commit into from
Apr 14, 2018
Merged

Convert YarnHelper to module #1868

merged 1 commit into from
Apr 14, 2018

Conversation

severisv
Copy link
Contributor

matthid
matthid reviewed Apr 13, 2018
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only some minor details.

src/app/Fake.JavaScript.Yarn/Yarn.fs Outdated
/// - 'setParams' - set command parameters
/// ## Sample
///
/// Target.Create "Restore-frontend" (fun _ ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe adapt docs (Target.create). Or we leave target out completely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree to leave it out, kinda overkill :)

src/legacy/FakeLib/YarnHelper.fs
@@ -29,6 +29,7 @@ let private yarnFileName =
proc.StandardOutput.ReadLine()
| _ -> "/usr/bin/yarn"

[<System.Obsolete("FAKE0001 Use the Fake.JavaScript.Yarn module instead")>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the attribute to the module as well.

src/app/Fake.JavaScript.Yarn/Yarn.fs Outdated
| Custom of string

/// The Yarn parameter type
[<CLIMutable>]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no more climutable

@matthid
Copy link
Member

matthid commented Apr 13, 2018

@severisv
Copy link
Contributor Author

I have updated the branch fixing the requested changes, let me know if there's anything else.
I'll submit an update removing the bloat from the npm module aswell

@matthid matthid changed the base branch from master to rc_5 April 14, 2018 10:53
@matthid
Copy link
Member

matthid commented Apr 14, 2018

Thanks!

@matthid matthid merged commit fb4552c into fsprojects:rc_5 Apr 14, 2018
@matthid matthid mentioned this pull request Apr 17, 2018
Closed
@severisv severisv deleted the f_port_yarn_to_module branch April 20, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@severisv @matthid