Add Fake.Net.Http documentation & API update #1759
Conversation
vlukash
commented
Jan 18, 2018
vlukash
commented
- Add Fake.Net.Http documentation
- Change API to throw exceptions in case of error, so it's consistent with other APIs
|
Related to #1746 |
vlukash
force-pushed
the
vlukash/http_downloader_doc
branch
2 times, most recently
from
86f0354
to
14ff268
Compare
|
Seems like documentation is not autogenerated (from *.dll) for the netcore projects if *.fs files aren't included in the legacy FakeLib.fsproj. In this case, I don't see Fake.Net.Http namespace in the I can probably modify "GenerateDocs" target in build.fsx, or include *.fs files in the FakeLib.fsproj @matthid, do you know what is the right way to autogenerate docs for netcore projects? |
|
Actually, I think the easiest way is to just include it into fakelib until we have worked that out... |
vlukash
force-pushed
the
vlukash/http_downloader_doc
branch
from
14ff268
to
e999fc4
Compare
|
Got it, thanks! |
| @@ -3,11 +3,13 @@ | |||
| open Fake.Net.Async | |||
| open Fake.Net.Result | |||
|
|
|||
| /// [omit] | |||
| // List extensions for traversing Result and Async types | |||
| // Functions from fsharpforfunandprofit.com, please see details here: | |||
| // https://fsharpforfunandprofit.com/posts/elevated-world-5/ | |||
| module List = | |||
There was a problem hiding this comment.
Maybe we should mark that internal?
| @@ -1,7 +1,9 @@ | |||
| namespace Fake.Net.Result | |||
|
|
|||
| /// [omit] | |||
| module Result = | |||
|
I think there is a place in build.fsx which needs to be edited if a new namespace (like |
