Refactor GitHub API

[csmager]

The primary change here is to allow the user to specify the release property values explicitly when creating a GitHub release. The previous createDraft / createRelease API enforced that the release name matched the tag name and that the body was set to a newline delimited set of release notes.

CreateRelease uses a similar pattern to a lot of Fake modules in that you can override the default params where required.

CreateDraftWithNotes DraftNewRelease keeps the previous opinionated behaviour of createDraft for users who are happy with that.

As this is a breaking change and Fake 5 is as-yet unreleased, I also pascal cased the functions to be more consistent with the rest of the Fake modules. Happy to revert this if the prevailing opinion is to the contrary.

Closes #1723

[csmager]

Will need some advice on how to fix the build given this is a breaking change to the API. If I change build.fsx to use the new API it won't run at all & if I don't change it then it will fail to bootstrap itself.

[matthid]

When bootstrapping you can assume that BOOTSTRAP is defined, therefore #if BOOSTRAP should work.

[csmager]

OK - and then we remove the conditionals once merged? Sounds good. Sorry, a bit new to this!

[matthid]

No problem, actually this is quite new as I was running into the same problem several times already ;)

[matthid]

question is if we should add owner repoName and tagName to the record as well. It "might" help to provide same script internal defaults if you create releases to multiple repos with the same owner.

I don't have a strong opinion on that, just something that crosses my mind. Question is if we can provide reasonable defaults for any of those parameter (but we already have APIs which have mandatory arguments in the record without default)

[csmager]

I had considered, but thought as we had no defaults & they were required that it was better to explicitly call out they were required. I suppose it's nice that you could do CreateRelease "owner" "repo" "v1.0" id ... and it would just work.

[csmager]

Struggling a bit with this bootstrapping. I've got the #if BOOTSTRAP condition, and the new code is ignored on first run as expected. I can see the call in the log to run the script again:

build/FAKE.exe testbuild.fsx PrintColors --fsiargs "--define:BOOTSTRAP" -pd

But it's failing with messages that imply it doesn't have BOOTSTRAP defined at all.

testbuild.fsx(930,16): error FS0039: The value, constructor, namespace or type 'createClientWithToken' is not defined. Maybe you want one of the following:
    CreateClientWithToken
    CreateClient
    CreateGHEClientWithToken
    CreateGHEClient
    CreateDraftWithNotes

I've pushed the change anyway.

[csmager]

OK, I think I've found it. -pd isn't an option in Cli.fs for netcore. It seems -pd was 'print details' in the old cli. If I change to -p, it works. If I remove, it works.

[matthid]

Actually we have two command lines:

1. The old full framework based (legacy FAKE.exe)
2. The new netcore based (FAKE 5)

The command lines differ. I failed at not noticing that -pd in the old command line needs to be before --fsiargs as everything after it will not be noticed by FAKE and given to fsi.

Thanks for taking care of this. Your change (ie removing -pd) is fine as well.