Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added executeFSIWithArgsAndReturnMessages #1719

Merged
merged 1 commit into from
Jan 2, 2018

Conversation

pr-yemibedu
Copy link
Contributor

Added executeFSIWithArgsAndReturnMessages to coincide with existing executeFSIWithArgs and executeFSIWithScriptArgsAndReturnMessages functions. This brings inline functionality to give the caller a handle on messages generated on execution.

Added executeFSIWithArgsAndReturnMessages to coincide with existing executeFSIWithArgs and executeFSIWithScriptArgsAndReturnMessages functions. This brings inline functionality to give the caller a handle on messages generated on execution.
@matthid
Copy link
Member

matthid commented Oct 28, 2017

I can take it but I think this module needs a complete redesign/new api.

@pr-yemibedu
Copy link
Contributor Author

Hello,
Since I still use FAKE 4.63.2 for my projects, this would help greatly. If you also want a general rewrite, that can happen as well. Should that be discussed on gitter.im or should there be a ticket with the pending issues of the module? Thank you. Good day.

@matthid
Copy link
Member

matthid commented Dec 15, 2017

If we merge this into master it will not land in any 4.X release anyway.

@pr-yemibedu
Copy link
Contributor Author

Hello,
I did not know that some merges were being excluded. Is it the case that fixing or cleaning for the 4.x is not fruitful for the efforts? I wanted to have this available from upstream. You let me know what the best course of action should be. Thank you. Good day.

@matthid
Copy link
Member

matthid commented Dec 15, 2017

One problem is that I never managed to get the Fake4 release process running on my system. So we always need to ask @forki nicely about a release.
The second problem is that we need this pr to go onto the hotfix_fake4 branch.

Strictly speaking this is not a hotfix, but since this is a FAKE 4 only feature anyway, I would not mind this change.

@pr-yemibedu
Copy link
Contributor Author

Hello,
I see this now under General Considerations. I will try to stay on track in the future. Thank you. Good day.

@matthid
Copy link
Member

matthid commented Jan 2, 2018

I'll merge this into master now. If you want to use is you can just use the next release of the 5.X package.

@matthid matthid merged commit 489e9ff into fsprojects:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants