Add Paket helper to push specific files #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthid
reviewed
Sep 18, 2017
| /// | ||
| /// - `setParams` - Function used to manipulate the default parameters. | ||
| let Push setParams = | ||
| let parameters : PaketPushParams = PaketPushDefaults() |> setParams |
There was a problem hiding this comment.
I think we can just remove this line.
There was a problem hiding this comment.
This is used to get the WorkingDir for the globbing pattern below.
I can change the functions so we don't evaluate setParams twice.
There was a problem hiding this comment.
Oh wow apparently I'm blind, thanks ;)
So you suggest to (fun _ -> parameters), correct? Yes we can do that.
|
Thanks! |
A function to push certain packages, not every package in the working directory.
inosik
force-pushed
the
paket-helper/push-files
branch
from
871dc62
to
394e44b
Compare
|
I rebased my branch on top of master. As of me, this is ready. |
|
Yep looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Paket.PushFilestask, which can be used to push specific packages.Currently the parameters get evaluated twice, is this OK?
I also added a missing assignment to
ProcessStartInfo.WorkingDirectory.