Add support for custom NuGet symbol feed during push #1549
Conversation
src/app/FakeLib/NuGet/NugetHelper.fs
Outdated
|
|
||
| // Newer NuGet requires source to be always specified, so if PublishUrl is empty, | ||
| // ignore symbol source - the produced source is broken anyway. | ||
| let normalize str = if str = "" then null else str |
There was a problem hiding this comment.
If we use option here its probably more idiomatic
There was a problem hiding this comment.
Could you please show a sample of your idea? I'm not sure I got it entirely..
There was a problem hiding this comment.
I thought like if IsNullOrEmpty str then None else Some str with appropriate changes in the match. It was just an idea, maybe it just looks more ugly in that case ...
There was a problem hiding this comment.
@matthid Indeed, with options it looks much better. I've updated my commit.
| @@ -91,6 +93,8 @@ let NuGetDefaults() = | |||
| WorkingDir = "./NuGet" | |||
| PublishUrl = null | |||
There was a problem hiding this comment.
Do you think we should change this default or do it like nuget and throw an error? (I know its unrelated to this PR, but it might make sense to fix that as well)
There was a problem hiding this comment.
There is a separate issue about defaults and I'd prefer to fix it via separate PR.
do it like nuget and throw an error
It's a dangerous change, because previous versions of Nuget worked fine without source specified. If we start to require the source now, it would be a breaking change.
Since NuGet 3.5 it's possible to specify a custom symbol feed. That allows to publish package to a custom feed together with its symbols.
|
I'm really a bit sceptical about adding features to FAKE 4 but thanks :) |
|
I'm a bit new to FAKE, so am not aware of its plans. Is there something wrong with adding new features to v4?
Again, I don't know a lot about your channels. Wouldn't it be enough to simply put this information to the Release Notes? Do you need some actions from my side? :) |
|
Nvm I was mostly speaking to myself. Problem is I did a major port to netcore and every feature we add to fake4 I basically need to port again to fake 5. I'm a bit concerned that I cannot keep up with the world when we allow people to still add them... I guess you got lucky and don't need to do anything because I haven't figured it out jet ;) |
|
@matthid Got it. That's great that nothing from my side is required :) Could you please trigger a new release of FAKE 4, so I can consume the changes in the downstream projects? |
|
@forki I've noticed that usually you make new releases. So could you please trigger a new FAKE release so I consume the latest changes? 😊 |
|
usually I'm also the one qho merges. @matthid we need to talk about process here. |
|
released. |
|
@forki Thank you 👍 |
|
@matthid BTW, I've noticed that changes I added in PR are left in the obsolete FakeLib. The replacement doesn't contain the feature. Does it mean that I need to fire yet another PR to move this feature to the new location as well? |
|
@zvirja Nice catch. Seems like this slipped through somehow. Yes a PR would be awesome ;) |
Starting from NuGet 3.5 it's now possible to publish package together with its symbols for the custom feeds as well (previously it was possible for the official feed only).
I've extended the
NuGetParamswith theSymbolPublishUrlandSymbolAccessKeyproperties, so thatNuGetPublishandNuGetfunctions will publish package with its symbols if theSymbolPublishUrlis specified.