Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added options for better TC reporting of npm tasks #1510

Merged
merged 1 commit into from
Apr 9, 2017

Conversation

mheuser
Copy link
Contributor

@mheuser mheuser commented Mar 29, 2017

This pull request will make it able to have nicer teamcity reporting for npm test tasks (with tc reporting) since we ca now have special npm commands "RunTest" and "Test" for calling "npm run %s --silent" or "npm test --silent" which will throw a unit test exception (no tc failure reporting at the end / npm error reporting, see npm:8821).

I also added a RunSilent task to be able to fail stuff withouth the npm error output.

For (manual) testing I've also added a sample npm+grunt project, needs node installed (only tried with mono yet):

# Trick the TC detection locally
FAKE/Samples/WebNpmGrunt > export TEAMCITY_VERSION="10"

# Default Target is "Test <== Install" / There should be no tc buildStatus / npm err msg on the end of the build log
FAKE/Samples/WebNpmGrunt > mono ../../build/FAKE.exe build.fsx

# There should be no tc buildStatus / npm err msg on the end of the build log
FAKE/Samples/WebNpmGrunt > mono ../../build/FAKE.exe build.fsx RunTest

# There should be no npm err msg on the end of the build log
FAKE/Samples/WebNpmGrunt > mono ../../build/FAKE.exe build.fsx RunSilent

# Should be same as before this PR / there aare npm err msg and a buildStatus msg
FAKE/Samples/WebNpmGrunt > mono ../../build/FAKE.exe build.fsx Run

Would be nice to see this soon in master 😃 . And thanks for FAKE 🙌 !

@forki
Copy link
Member

forki commented Apr 9, 2017

Thanks!

@forki forki merged commit a2e91d6 into fsprojects:master Apr 9, 2017
@mheuser mheuser deleted the better-npm-tc-reporting branch April 10, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants