Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of GitLab CI with current multi-runner #1345

Merged
merged 1 commit into from
Aug 9, 2016
Merged

Fix detection of GitLab CI with current multi-runner #1345

merged 1 commit into from
Aug 9, 2016

Conversation

pdfforge
Copy link

@pdfforge pdfforge commented Aug 3, 2016

As it seems, the latest multi-runner has changed the content of the "CI_SERVER_NAME" variable to "GitLab" instead of "GitLab CI". In the docs (http://docs.gitlab.com/ce/ci/variables/README.html), they state that we should use the variable "GITLAB_CI", as it is explained with "Mark that build is executed in GitLab CI environment". It is set to the string "true", when we are in GitLab.

As it seems, the latest multi-runner has changed the content of the "CI_SERVER_NAME" variable to "GitLab" instead of "GitLab CI". In the docs (http://docs.gitlab.com/ce/ci/variables/README.html), they state that we should use the variable "GITLAB_CI", as it is explained with "Mark that build is executed in GitLab CI environment". It is set to the string "true", when we are in GitLab.
@forki forki merged commit e0ff22a into fsprojects:master Aug 9, 2016
@forki
Copy link
Member

forki commented Aug 9, 2016

thx!

@forki
Copy link
Member

forki commented Aug 9, 2016

I changed it to

let isGitlabCI = getEnvironmentVarAsBool "GITLAB_CI" || environVar "CI_SERVER_NAME" = "GitLab CI"

@pdfforge
Copy link
Author

pdfforge commented Aug 9, 2016

Thank you for merging it! Of course, the change is fine, although the documentation says that the GITLAB_CI variable is available in all multi-runner versions since the first, I would not be surprised if there were exceptions and we know that CI_SERVER_NAME contained the proper value for old runner versions

@pdfforge pdfforge deleted the patch-1 branch August 9, 2016 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants