NuGet.Restore.RestoreMSSolutionPackages quoting seems broken

[0x53A]

    for s in solutions do
        NuGet.Restore.RestoreMSSolutionPackages (fun x -> { x with
                                                                OutputPath = (Path.GetDirectoryName s) @@ "packages"
                                                                Verbosity = NuGet.Restore.NugetRestoreVerbosity.Quiet
                                                                Sources = [ @"C:\Projekte_BUILD\a_CommonBinaries\nuget" ] }) s

PS C:\_build\fake-bootstrap> dotnet fake --version
FAKE 5 - F# Make (5.0.0-rc012.95+vsts.617e5c3e3ac66e15fd822f03d531fe4dce04dd85)
FakePath: C:\Users\rieluk\.nuget\packages\fake.runtime\5.0.0-rc012.95\lib\netstandard2.0\Fake.Runtime.dll

The whole quoting code looks suspicious, CLI passing on windows is a bleeping mess.

[matthid]

I think we now have a working quoting implementation in place. Problem is I might have mixed that with existing code trying to do manual quoting. Once that is figured out it should work correctly.

In particular I'm pretty sure that https://github.com/fsharp/FAKE/blob/master/src/app/Fake.Core.Process/CmdLineParsing.fs is working (I use it on various projects with weird command line arguments). Point is that we now need to ensure that whatever we give into:

https://github.com/fsharp/FAKE/blob/d099facbe19ed1676e66c74fef295baa43a73c66/src/app/Fake.DotNet.MSBuild/MSBuild.fs#L309

is the correct list of arguments.
Can you take a look and come up with a PR?

[matthid]

Ah wait you are talking about nuget task. We probably need to do the same as we did for the msbuild task and use Args.toWindowsCommandLine with the correct raw argument list (no quoting required)

[0x53A]

Wanted to send something tonight, but need to go. Will try again next evening ;D

please ping if I don't.

[matthid]

@0x53A ping :)

[matthid]

I'm not even sure what I just saw... 92cd82b

[0x53A]

lol. That is def bonkers.

Ich hab gerade ein schlechtes Gewissen bekommen und wollte auch noch schnell einen PR senden (was ich ja schon am Freitag wollte :D), aber ich glaube mein Computer sagt mir ich soll schlafen gehen ...¯_(ツ)_/¯

[matthid]

Don't worry about it. I was bored while waiting for a build ;)
that lock thing might indicate that you should get latest and do a global restore and/or update dotnet sdk to the latest preview (works pretty good on my machine with the global fake-cli tool)

[matthid]

However it will not be part of rc16 (because that was the build I was waiting on)