Remove Version.Parse check from global.json parsing

fsprojects · Aug 30, 2024 · db3ad16 · db3ad16
1 parent 7ef3837
commit db3ad16
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -2,6 +2,7 @@
 
 ## 6.1.1 - 2024-08-19
 * BUGFIX: Assembly resolver to pick a found SDK instead of first SDK - https://github.com/fsprojects/FAKE/pull/2797/files
+* BUGFIX: Fix issue parsing global.json when using prerelease .NET SDKs, thanks @numpsy - https://github.com/fsprojects/FAKE/issues/2803
 
 ## 6.1.0 - 2024-07-27
 * BUGFIX: MSBuild.build adds a bad string at the end of properties, thanks @0x53A - https://github.com/fsprojects/FAKE/issues/2738

diff --git a/src/app/Fake.DotNet.Cli/DotNet.fs b/src/app/Fake.DotNet.Cli/DotNet.fs
@@ -69,10 +69,7 @@ module DotNet =
 
                 match sdk.Property("version") with
                 | null -> None
-                | version ->
-                    let versionValue = version.Value.ToString()
-                    let _ = Version.Parse(versionValue)
-                    Some versionValue
+                | version -> Some(version.Value.ToString())
             with exn ->
                 failwithf "Could not parse `sdk.version` from global.json at '%s': %s" globalJson.FullName exn.Message