Close event listeners on EOF #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ener receives an EOF.
|
Hi @rafrombrc, sorry for taking so long for having a look in this pull request, I will merge it and try to add some tests. Thanks for working on it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An EOF or UnexpectedEOF error on the APIEvent decode operation typically means that the Docker daemon has stopped. In any event, it causes the HTTP response handler embedded in eventHijack to exit, which means that all existing registered listeners will no longer work, even if the daemon comes back, but the listeners themselves don't know anything has happened. This change causes the listener channels to be closed, which notifies client code that the listeners are no longer useful and new ones should be created and registered. This closes #163.