-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electric symbol requests #23
Comments
sriniv1422, symbols added. |
if u can create a separate category called simple NMOS and Simple PMOS that will be even better |
I am following these two guidelines: https://en.wikipedia.org/wiki/MOSFET#Circuit_symbols What is exactly wrong with PMOS? |
fsmMLK when i use the latest menu this is what i get close to what i want notice that the gates of NMOS and PMOS and either low or high and not centered. This is a very old convetion and no one uses these nowadays. Actually in the link https://en.wikipedia.org/wiki/MOSFET#Circuit_symbols the BJT transistors you created are of excellent quality, they turn out to be really good in presentations and papers, I really appreciate if you can make them like BJT. it would look awesome |
How does it look now? (OBS: these changes were not commited to github yet) I made the gate centered for all 3-terminal (no bulk). I am thinking of keeping S/D positions as they are now and the user check to swap S/D if they want. It will make my code cleaner and I don't think this will cause too much trouble to the user. Now the linewidth I am not sure. I think uniform line width makes the symbol very 'fat', specially if we draw the body diode or the envelope (see below). Arrow size is slightly smaller in MOS otherwise the arrow would be too big for the tight space of the symbol ( I don't want to make the entire symbol larger just to acommodate the larger arrow. |
Looks good fsmmlk. please go ahead and make the code change to git hub. Lets keep the thick line . I like it that way better and is consistent . I wont be using the envolope option or body diode anyways. I like to keep it consistent with BJT and for that the thick is perfect. Iam ok with sawpping D/S to get to what I want for PMOS if that means less code change for you. |
Looks good fsmmlk. please go ahead and make the code change to git hub.
Lets keep the thick line . I like it that way better and is consistent . I
wont be using the envolope option or body diode anyways. I like to keep it
consistent with BJT and for that the thick is perfect. Iam ok with sawpping
D/S to get to what I want for PMOS if that means less code change for you.
let me know when you are done uploading to github and I can try it out
…On Sun, May 2, 2021 at 5:19 AM fsmMLK ***@***.***> wrote:
How does it look now? I made the gate centered for all 3-terminal (no
bulk). I am thinking of keeping S/D positions as they are now and the user
check to swap S/D if they want. It will make my code cleaner and I don't
think this will cause too much trouble to the user.
[image: bitmap]
<https://user-images.githubusercontent.com/1710686/116809303-f49daf80-ab45-11eb-8f61-967ea20066a7.png>
Now the linewidth I am not sure. I think uniform line width makes the
symbol very 'fat', specially if we draw the body diode or the envelope (see
below). Arrow size is slightly smaller in MOS otherwise the arrow would be
too big for the tight space of the symbol ( I don't want to make the entire
symbol larger just to acommodate the larger arrow.
[image: g9370]
<https://user-images.githubusercontent.com/1710686/116809624-91ad1800-ab47-11eb-97ed-86bc9ee5d205.png>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT3XLODAXXF6SZCLZWFQXZLTLURMRANCNFSM4ZQJ6DYA>
.
|
Uploaded a new version. I made the FET use finer lines (0.7) when the envelop is present, otherwise thicker lines (1.0). If you want to have thick lines even with the envelopes, you can edit drawTransistors.py and change lineWidth to 1.0 (line ~176 ) |
fsmmlk ,
Looks good. much appreciate the help...
I wanted to ask you one more thing,
is it possible to create timing diagrams with your package.?
there is nothing out there that can create good timing diagrams except for
wavedrom.
we can talk further in case you are interested to implement it. that would
be a game changer for the entire community.
LEt me know..
with the mods you did , i can now draw good schematics.
thanks a lot..
…On Sun, May 2, 2021 at 3:16 PM fsmMLK ***@***.***> wrote:
Uploaded a new version.
I made the FET use finer lines (0.7) when the envelop is present,
otherwise thicker lines (1.0). If you want to have thick lines even with
the envelopes, you can edit drawTransistors.py and change lineWidth to 1.0
(line ~176 )
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT3XLOCQW6PXYRWPE6WWBG3TLWXIPANCNFSM4ZQJ6DYA>
.
|
Glad to hear that this extension is useful to people. Now, on timing diagrams, yes, it is possible to create one. I have some questions on that: |
fsmmlk
well just wanting to have everything under inkscape.
I agree with you that wavedrom can generate pretty diagrams..
If it is too much work, then no need.
…On Sun, May 2, 2021 at 4:09 PM fsmMLK ***@***.***> wrote:
Glad to hear that this extension is useful to people.
Now, on timing diagrams, yes, it is possible to create one. I have some
questions on that:
1-) What is the problem with wavedrom?
2-) Why would someone need something different? Wavedrom looks quite nice
and can generate pretty diagrams.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT3XLOB7UWCHNGFQHYZCCGDTLW5O7ANCNFSM4ZQJ6DYA>
.
|
I found a python module for wavedrom (https://pypi.org/project/wavedrom/). This is the best scenario since there is no need to reinvent the wheel and would make easier to integrate with inkscape. One idea could be to have an inkscape GUI/text interface for wavedrom embeded in inkscape. |
fsmmlk,
that would be awesome . I did not know that there was a python module
available for wavedrom. If you can integrate it in inkscape , that would be
great. Many people will start using it as everything is now available under
inkscape..
Can you do this ? If so , it will be of immense help.
…On Sun, May 2, 2021 at 4:24 PM fsmMLK ***@***.***> wrote:
I found a python module for wavedrom (https://pypi.org/project/wavedrom/).
This is the best scenario since there is no need to reinvent the wheel and
would make easier to integrate with inkscape.
One idea could be to have an inkscape GUI/text interface for wavedrom
embeded in inkscape.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT3XLODR3MGBDFERFWAMVMTTLW7KHANCNFSM4ZQJ6DYA>
.
|
I will take a look and create a small proof of concept example. I cannot promisse it will be quick. I would like to hear from you later what a good interface and features would be nice to have (I don't have experiente with wavedrom) Perhaps I will create a new private repository only for that and later integrate with circuitsymbols. |
fsmmlk
Sure. In fact it need not be as complex as wavedrom. It is enough if we are
able to create waveforms easily..
I can help you with features and interfaces . Let me know when you have
some thing ready and i can take a look at it.
Take your time, there is no hurry for this.
…On Sun, May 2, 2021 at 4:34 PM fsmMLK ***@***.***> wrote:
I will take a look and create a small proof of concept example. I cannot
promisse it will be quick.
I would like to hear from you later what a good interface and features
would be nice to have (I don't have experiente with wavedrom)
Perhaps I will create a new private repository only for that and later
integrate with circuitsymbols.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT3XLOFFWITYIE67TOUFCT3TLXANHANCNFSM4ZQJ6DYA>
.
|
Can you add RFIC symbols like these, please? https://github.com/cfriesicke/inkscape-schematic-symbols :) |
fsmMLK
have you made any attempts at wavedrom?
Srini
…On Sun, May 2, 2021 at 4:34 PM fsmMLK ***@***.***> wrote:
I will take a look and create a small proof of concept example. I cannot
promisse it will be quick.
I would like to hear from you later what a good interface and features
would be nice to have (I don't have experiente with wavedrom)
Perhaps I will create a new private repository only for that and later
integrate with circuitsymbols.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT3XLOFFWITYIE67TOUFCT3TLXANHANCNFSM4ZQJ6DYA>
.
|
Good morning, I wanted to thank you for your work, it is great. I was wondering if you could add some components to your list as this extension is very handy. I attach a .svg file I obtained from a YouTube video I commonly use magnetics and, by now, this tool only includes one type of coil and it would be great to have more variety (same with other components as power sources as dependent power voltage sources): On the other hand, would it be possible to add an extension for labeling BJT, FET and OpAmps as in the rest of devices? Thank you for your awesome contribution. |
Sure, I'm working on it now! =D what do you mean by "same with other components as power sources as dependent power voltage sources" |
Awesome, thank you very much!. Sorry I misswrote. I meant that some component, probably not based on official standards have different possibilites for being draw. Examples: And would be great to have variable DC power supplies added as in previous comment. Do you know some way of autojoin the component nets in inkspace? Thank you :). |
what transformer features would you like to have in this extension? I don't work much with transformers and don't know the features that are worth implementing. At the moment I have implemented:
|
Yes, that would be cool. Maybe some adjustable coils, coils with polarity or transformers with two or more secondary coils (with different cores). Thank you!. |
That looks great!, thank you. |
Transformers and variable components are now available! =D |
current wavedrom UNSTABLE version can be found here. Please give me feedback. https://github.com/fsmMLK/wavedromScape |
Would it be possible to choose the orientation of the component values? If I rotate 90º a resistor, I would like its name to stay horizontal, for example. EDIT: Nevermind, I didn't know I could just double click the value and change there... That's what I get for using inkscape for the first time. EDIT 2: Is it possible to change the thickness of the arrow in the transistors? I know I can change of the overall component, but I would like to have only the arrow a tad more pronounced. |
Please leave a message below with electric symbols you would like to have.
Please, if possible, add a picture of the symbol to help my life. =)
The text was updated successfully, but these errors were encountered: