-
Notifications
You must be signed in to change notification settings - Fork 56
Introduce csscomb #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Introduce csscomb #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🍕 👍 |
👍 |
@@ -2,6 +2,7 @@ | |||
|
|||
## Unreleased | |||
|
|||
- Introduce [CSSComb](https://github.com/csscomb/csscomb.js) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be great to have link to this pull request with such great description!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, fixed
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSSComb is a tool for placing CSS properties in any specific order, so you won't have issues with double properties declarations.
Let me explain it with example:
A developer may not spot the last
font-size
declaration and have an issue with element font-size. If properties are ordered:It's easy to spot duplicates
font-size
properties. It also helps in understanding how this particular code is styled. A developer sees clearly that this is a relatively positioned floating block.At the same time, we should not include
csscomb
in our build process because it has some issues (see fs/static-base#56 (comment)). Instead we should rely on scss-lint.If there is a need in violating sorting rules it can be disabled with:
/cc @timurvafin, @rustemginiyatullin, @mikheevdmitry