-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow building of solutions #5
base: master
Are you sure you want to change the base?
Conversation
…within solutions Fixing linting changes Fixing linting changes Fixing linting changes Fixing linting changes Fixing linting changes
…erverless-dotnet into feature/solutiondirs
It's backwards compatible, by the way. If you don't provide the settings, it works exactly as it currently does. |
@fruffin Any reason this hasn't been merged in? |
I apologize again for all the individual commits. Apparently there's a "Squash and merge" option for accepting PRs that will clean this up. But I'm going to practice my rebasing skills so I don't do this in a future PR ever again. |
@Perlkonig first of all, sorry for the delay on this one. The way I have been working with .Net projects so far was to have them in a solution as well, but I have never needed to build more than the "service" project, given that all its dependencies should be built at the same time too. Thanks for your help! |
Looks like I lied in my documentation update 😊 It's not building the whole solution, nor do you actually point to the solution root folder. You point to the actual project folder. I apologize for that error. This change is for anyone who wants to store their project in any subfolder, not just solutions, though that would be the most common, I would think. But perhaps I'm doing something wrong? Is it already possible to point to a subfolder? |
Perhaps I should change the setting name to |
My lambdas are in a solution to facilitate unit testing. This PR lets you specify a
custom:dotnet:slndir
setting in your service config and build from within that project.My editor made a bunch of indentation changes that I went back and undid, but then I couldn't make things squash, so hopefully you can just merge the PR as a single commit. Let me know if there's something else you'd like me to do.
Thanks!