Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pin react types versions #353

Merged
merged 2 commits into from
Apr 11, 2022
Merged

fix: pin react types versions #353

merged 2 commits into from
Apr 11, 2022

Conversation

LumaKernel
Copy link
Contributor

@testing-library/react depends on @types/react-dom@* and yarn
installs v18. It is not time to switch to v18. Then pin the versions of
them.

related: vercel/next.js#36019

Types of changes

  • Bug fixes
    • resolves #
  • Features
    • resolves #
  • Maintenance
  • Documentation

Changes

  • ...

Additional context

Community note

Please upvote with reacting as 👍 to express your agreement.

`@testing-library/react` depends on `@types/react-dom@*` and yarn
installs v18. It is not time to switch to v18. Then pin the versions of
them.
@github-actions github-actions bot added the bug Something isn't working label Apr 11, 2022
@LumaKernel LumaKernel merged commit 9228e09 into main Apr 11, 2022
@LumaKernel LumaKernel deleted the pin-type-version branch April 11, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant