Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BCM43143; #78

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

hermitcrabslab
Copy link

WARNING! Use only with supported firmware 1.8.6.1B_201603181307(tested) and up!

WARNING! Use only with supported firmware 1.8.6.1B_201603181307(tested) and up!
@tuaminx
Copy link
Contributor

tuaminx commented Aug 30, 2016

Please add a line to load crond from the startup.
/usr/sbin/crond -b

@hermitcrabslab
Copy link
Author

I am not sure what do you want to accomplish, can you elaborate?

 Author:    alpha14 <[email protected]>
 Date:      Fri Jun 10 13:18:02 2016 +0300
@tuaminx
Copy link
Contributor

tuaminx commented Aug 31, 2016

To be able to use crob job for scheduling task, we need:

# Check and create crontabs folder
crontab_folder="/var/spool/cron/crontabs"
if [ ! -r "$crontab_folder" ]; then
    mkdir -p "$crontab_folder"
fi
# Start crond
/usr/sbin/crond -b

Above script can be added after line led $(get_config LED_WHEN_READY) of test/equip_test.sh

In your instruction, there is a guidance to use crontab -e to add a new scheduling job to upload files to FTP server and delete old videos. It mentioned the /var/spool/cron/crontabs but it's not enough. crond daemon should be started so that jobs described by crontab -e can work.

@hermitcrabslab
Copy link
Author

Sorry but is not my code/instructions, is fritz-smh code.
IMHO best is if you fork his repository, made/test your changes then create a pull request like I did.
I highly doubt he has time to read all comments, having a pull request is more easy to spot it and also good for other devs to join/participate in the code.

@tuaminx
Copy link
Contributor

tuaminx commented Aug 31, 2016

Aha, I see.

I used to try making a PR but look like I did wrong way so I cannot push it. Then I thought that I need something like approval to do that but actually it's not.
OK, I will make another PR.
Thanks 😄

@fritz-smh
Copy link
Owner

Hi,

A bit late, but can I merge this PR or I should wait for another PR ?

@hermitcrabslab
Copy link
Author

Well kinda late now coz now we have conflicts, my branch with yours, since I corrected some mistakes from other commits, best is if you can cherry-pick my fork changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants