feat: proof engine zkboost ingreation test#10
Merged
frisitano merged 8 commits intoMar 19, 2026
Conversation
Add a new test crate `testing/proof_engine_zkboost` that verifies wire-level compatibility between lighthouse's HttpProofNodeClient and the zkboost Proof Node API. The test framework includes: - MockZkboostServer: axum-based mock server mimicking zkboost's HTTP API (POST/GET proof requests, SSE events, proof download, proof verification) - 8 integration tests covering all 4 API endpoints, SSE streaming, full request lifecycle, and proof_type encoding analysis Key bug fix found during integration testing: - HttpProofNodeClient::request_proofs was passing Vec<u8> directly to reqwest's .query() which serde_urlencoded doesn't support. Fixed to serialize proof_types as a comma-separated string matching zkboost's expected format. Known compatibility gap documented: - Lighthouse uses ProofType = u8 while zkboost uses string-based ProofType enum (e.g., "reth-sp1"). This mismatch exists in both query params and SSE event payloads. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restructure test names, docs, and assertions to explicitly categorize each test as either "compatible transport" (works today) or "compatibility boundary" (ProofType encoding mismatch). Tests now assert the actual wire format rather than just logging, making the gap visible in test output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add inline comment documenting that the serde_urlencoded serialization bug was discovered by the proof_engine_zkboost integration tests, not caught by existing unit tests because MockProofNodeClient bypasses HTTP. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Which issue # does this PR address?
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.