Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fibers instead of monkey patching #8

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Use fibers instead of monkey patching #8

merged 1 commit into from
Aug 14, 2022

Conversation

WyriHaximus
Copy link
Member

Depends on: reactphp/async#15

@WyriHaximus WyriHaximus added this to the v2.0.0 milestone Nov 21, 2021
@WyriHaximus WyriHaximus changed the title [WIP] Use fibers instead of monkey patching Use fibers instead of monkey patching Nov 26, 2021
@WyriHaximus WyriHaximus marked this pull request as ready for review November 26, 2021 16:56
@WyriHaximus
Copy link
Member Author

@SimonFrings @clue @jsor Updated it to the newly released react/async v4. This code is rock solid, been using it in production for over half a year now without any issues.

Copy link

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WyriHaximus Good job! Only briefly eyeballed this, but looks like a major improvement over the previous monkey patching! 👍 Also using similar logic myself to add PSR-15 compatibility for Framework X as discussed in clue/framework-x#185.

@WyriHaximus WyriHaximus merged commit 078431f into master Aug 14, 2022
@WyriHaximus WyriHaximus deleted the fibers branch August 14, 2022 21:25
@WyriHaximus
Copy link
Member Author

@clue Thanks! It's been a lot easier to use and no more weird bigs due to incompatible code. In the future I hope we can build PSR-15 support directly into react/http when the time is there, but until that we can use this middleware or framework-x to achieve the same. Will tag a release for this tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants