Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support direct reply-to feature #82

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

yuryfunikov
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Dec 25, 2019

Codecov Report

Merging #82 into master will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #82      +/-   ##
============================================
+ Coverage     93.56%   94.03%   +0.47%     
- Complexity      432      442      +10     
============================================
  Files            38       38              
  Lines          1025     1040      +15     
  Branches         43       45       +2     
============================================
+ Hits            959      978      +19     
+ Misses           48       47       -1     
+ Partials         18       15       -3
Impacted Files Coverage Δ Complexity Δ
.../com/github/fridujo/rabbitmq/mock/MockChannel.java 89.71% <100%> (+0.77%) 116 <14> (+7) ⬆️
...va/com/github/fridujo/rabbitmq/mock/MockQueue.java 94.97% <0%> (+2.01%) 75% <0%> (+3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 375fe25...c67d7b4. Read the comment docs.

@ledoyen
Copy link
Contributor

ledoyen commented Dec 31, 2019

Hi, thanks for the PR.

I am not sure about creating a "real" queue for amq.rabbitmq.reply-to as it is supposed to be an un-deletable pseudo-one, , but for now, it will do.

Please do the following changes before I can merge :

  • Replace JUnit assertions by assertj one
  • Squash all commits in one

Thanks for your work

@ledoyen ledoyen self-requested a review December 31, 2019 09:09
@yuryfunikov yuryfunikov force-pushed the feature/direct-reply-to-support branch from c0064e9 to c71b6fc Compare January 5, 2020 20:41
@yuryfunikov yuryfunikov requested a review from ledoyen January 5, 2020 20:49
@yuryfunikov yuryfunikov force-pushed the feature/direct-reply-to-support branch from 49a50a5 to 8b1ae79 Compare January 5, 2020 20:53
@yuryfunikov yuryfunikov force-pushed the feature/direct-reply-to-support branch from 144fdd3 to c67d7b4 Compare January 14, 2020 19:03
@ledoyen
Copy link
Contributor

ledoyen commented Jan 15, 2020

Seems solid !
Thanks for all your hard work.

@ledoyen ledoyen merged commit 357c570 into fridujo:master Jan 15, 2020
@ledoyen
Copy link
Contributor

ledoyen commented Feb 9, 2020

Solves #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants