Escaped params #146
Merged
Escaped params #146
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an attempt to fix fridays#145, I found that there was no test verifying the current behavior of escaping params. This test should help prevent future regressions.
Fixes fridays#145 When urls are constructed in the `Link` component, all params are URI encoded so that they won't break routing. When params are read however, they are never decoded. This leads to an inconsistent behavior between the server and the client when params are passed down the page component as `query`. On the server, they come down untouched (encoded). On the client, they are not encoded. Consider this link: <Link route="foo" params={{ b: 'f/g' }}><a>Foo</a></Link> and this page component FooPage.getInitialProps = async ({ query }) => { console.log(query.b); } On the server, this page would log "f%2Fg" when navigated to. On the client it would log "f/g". By decoding params before they are injected into the `query` params, we get the same behavior on the client and the server. We also make the behavior consistent with how regular query params work.
|
Ping @fridays, not sure if you watch new PRs coming in. |
|
Thank you, great catch! |
petertulala
added a commit
to petertulala/next-routes-with-locale
that referenced
this pull request
Jan 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When urls are constructed in the
Linkcomponent, all params are URIencoded so that they won't break routing. When params are read however,
they are never decoded. This leads to an inconsistent behavior between
the server and the client when params are passed down the page component
as
query. On the server, they come down untouched (encoded). On theclient, they are not encoded.
Consider this link:
and this page component
On the server, this page would log "f%2Fg" when navigated to. On the
client it would log "f/g".
By decoding params before they are injected into the
queryparams, weget the same behavior on the client and the server. We also make the
behavior consistent with how regular query params work.