Feat/theme demo #544
Open
Feat/theme demo #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(tabs): adding necessary css variables to theme tabs
kishore-kumar-E3682
requested review from
arvindanta,
parsuram-vijaysankar and
kaushal-freshworks
arvindanta
requested changes
Apr 12, 2022
| @@ -1,50 +1,58 @@ | |||
| /** | |||
| @prop --fw-button-min-width: minimum width for the button | |||
| @prop --fw-button-label-vertical-padding: vertical padding for the button label | |||
| @prop --fw-button-height: The height of the normal button. | |||
| @prop --fw-button-small-height: The height of the small button. | |||
| @prop --fw-button-border-radius: The height of the small button. | |||
There was a problem hiding this comment.
if this is for only small button, can we also add small to the css variable ?
There was a problem hiding this comment.
Its a typo, modified it.
| @prop --fw-button-border-radius: The height of the small button. | ||
| @prop --fw-button-font-weight: The font weight of the button. | ||
| @prop --fw-button-font-size: The font size of the normal button. | ||
| @prop --fw-button-small-font-size: The font size of the small button. |
There was a problem hiding this comment.
should we also provide customisation for other sizes of button like 'icon' , icon-small also?
There was a problem hiding this comment.
The icons are passed as slots so we can change the icon size from there.
styles/_utils.scss
Outdated
| @@ -2,6 +2,7 @@ | |||
| @import 'mixins/card'; | |||
| @import 'mixins/spacing'; | |||
| @import 'mixins/border'; | |||
| @import './theme.base'; | |||
There was a problem hiding this comment.
why we need this import here inside utils ?
There was a problem hiding this comment.
Moved the them.base code to the theme.scss file.
arvindanta
reviewed
Apr 20, 2022
arvindanta
requested changes
Apr 20, 2022
arvindanta
reviewed
Apr 21, 2022
|
Please do not merge to |
feat(theming): Update color, font-size & font-weight variables
feat(theming): update color codes of components
- Button - Primary & Secondary - Label - Input
- Button - Primary & Secondary - Label - Input
feat(theming): update components with css custom variables - CRM theme
feat(theming): update inline banner component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moved the colors sass variables to a generic (from
azure-800tocolor-info-800) which can be overwritten by the css variable--fw-color-info-800. Also exposed the typography and padding / height for button and tabs.Checklist:
How Has This Been Tested?