Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): fw-tooltip on hovering over data-table row action buttons #447

Merged
merged 5 commits into from
Mar 1, 2022
Merged

fix(data-table): fw-tooltip on hovering over data-table row action buttons #447

merged 5 commits into from
Mar 1, 2022

Conversation

Vignesh-Manogar-E3433
Copy link
Contributor

@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 commented Mar 1, 2022 •
edited
Loading

Fixes in this PR:
These are fixes suggested by design team. doc: https://docs.google.com/spreadsheets/d/1f8kTSWK2eTkAKCnW6-03ptRpqC2YigSe0gcdfuKwFTI/edit?usp=sharing

  • Table row min height to 64px.
  • Modal slider slide-in animation improved as suggested by design team.
  • Changed from default tooltip to fw-tooltip inside DataTable.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

Fixes were individually tested in Chrome browser.

@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 changed the title Fix/data table 6 fix(data-table): fw-tooltip on hovering over data-table row action buttons Mar 1, 2022
@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 merged commit 7e00fd6 into canary Mar 1, 2022
@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 deleted the fix/data-table-6 branch March 1, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindanta arvindanta arvindanta approved these changes

@kaushal-freshworks kaushal-freshworks Awaiting requested review from kaushal-freshworks

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vignesh-Manogar-E3433 @arvindanta