Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-table): isloading as mutable property #420

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix(data-table): isloading as mutable property #420

merged 1 commit into from
Feb 11, 2022

Conversation

Vignesh-Manogar-E3433
Copy link
Contributor

@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 commented Feb 11, 2022 •
edited
Loading

  • Making isLoading property for table as a mutable property.
  • Removing table last row border as datatable generally does not have a border on its own.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 merged commit 2ef8029 into canary Feb 11, 2022
@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 deleted the fix/data-table-3 branch February 11, 2022 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindanta arvindanta arvindanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vignesh-Manogar-E3433 @arvindanta