Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fw-input): Added slots and modified styles for fw-input based on DSM #395

Merged
merged 7 commits into from
Feb 9, 2022

Conversation

kishore-kumar-E3682
Copy link
Contributor

@kishore-kumar-E3682 kishore-kumar-E3682 commented Feb 3, 2022

  • changed the disabled background-color to #f7f9fa
  • removed the bottom spacing on the input and increase the font-size to 14px
  • reduced the size of the close icon to 8px
  • changed the font-weight for the disabled state and placeholder
  • exposed css variables to change the normal state font color of label and hint
  • modified fw-input as a block element so that consuming component can add their margin or padding
  • Added slots to create custom input as shown below

Screenshot 2022-02-04 at 4 52 19 PM

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

changes the disabled background-color, padding and margin
@kishore-kumar-E3682 kishore-kumar-E3682 changed the title fix(fw-input): modified styles for fw-input based on DSM feat(fw-input): Added slots and modified styles for fw-input based on DSM Feb 4, 2022
Copy link
Contributor

@sangeet-fw sangeet-fw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kishore-kumar-E3682 kishore-kumar-E3682 merged commit 1f5b846 into canary Feb 9, 2022
@kishore-kumar-E3682 kishore-kumar-E3682 deleted the input-style-fix branch February 9, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants