Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fw-tag): font size and padding fix #376

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Conversation

kishore-kumar-E3682
Copy link
Contributor

increased font size to 14px and changed padding/margin

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

increased font size to 14px and changed padding/margin
Copy link
Contributor

@kaushal-freshworks kaushal-freshworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fw-avatar {
padding-right: 8px;
}
Why this change? Apart from this every thing looks good.

@kishore-kumar-E3682
Copy link
Contributor Author

fw-avatar { padding-right: 8px; } Why this change? Apart from this every thing looks good.

I have replaced the margin 6px with the padding 4 px to the parent container as per DSM but kept the 8px margin-left as padding right: 8px to provide some gap between the avatar and the span/text next to it.

@kishore-kumar-E3682 kishore-kumar-E3682 merged commit c6ad237 into canary Jan 20, 2022
@kishore-kumar-E3682 kishore-kumar-E3682 deleted the tag-font branch January 20, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants