Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): slider variant position justify-content to flex-end #369

Merged
merged 1 commit into from
Jan 12, 2022
Merged

fix(modal): slider variant position justify-content to flex-end #369

merged 1 commit into from
Jan 12, 2022

Conversation

Vignesh-Manogar-E3433
Copy link
Contributor

@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 commented Jan 12, 2022 •
edited
Loading

Issue:
Slider variant in Modal component appears in left side rather than the expected right side.

Fix:
Flex justify-content 'right' does not work consistently across browsers. So changing the property value to 'flex-end'.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

Tested the fix in Safari, chrome browsers.

@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 merged commit a7aff28 into canary Jan 12, 2022
@Vignesh-Manogar-E3433 Vignesh-Manogar-E3433 deleted the fix/slider-position branch January 12, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindanta arvindanta arvindanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vignesh-Manogar-E3433 @arvindanta