Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(date-picker): add input type variant for single date and range selection datepicker #303

Merged
merged 19 commits into from
Dec 3, 2021
Merged

feat(date-picker): add input type variant for single date and range selection datepicker #303

merged 19 commits into from
Dec 3, 2021

Conversation

kulkarni-kashyap
Copy link
Contributor

@kulkarni-kashyap kulkarni-kashyap commented Nov 23, 2021 •
edited
Loading

  • Add input type variant for single date selection
  • Add keyboard nav support
  • Make datepicker inert
  • Change styles to align with DSM standards for single date and date range selection

Sample screenshots:

  • Single Date picker

Screenshot 2021-12-03 at 2 19 58 PM

  • Date Range picker

Screenshot 2021-12-03 at 2 20 28 PM

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My commits have standard messages as mentioned in Contributing Guidelines

How Has This Been Tested?

@kulkarni-kashyap
feat(date-picker): add input type variant for single date and range s…
1985883 
…election datepicker

Add input type variant for single date and date range selection, add keyboardnav support, make
datepicker inert, Change styles to align with DSM standards
@kulkarni-kashyap
docs(date-picker): correct story label
2bc6af7
@kulkarni-kashyap kulkarni-kashyap marked this pull request as ready for review November 24, 2021 04:35
@kulkarni-kashyap kulkarni-kashyap mentioned this pull request Nov 25, 2021
Closed
6 tasks
@kulkarni-kashyap
fix(date-picker): show current month and year if invalid date is prov…
113e75d 
…ided
@kulkarni-kashyap
chore: merge with canary
9b07cad
@kulkarni-kashyap
fix(select): fix incorrect value assignment
d015cae
@kulkarni-kashyap
fix(datepicker): handle ISO dateformats
84a0127
@kulkarni-kashyap
fix(date-picker): show current date if invalid date is passed in
8e1f007
@kulkarni-kashyap
refactor(date-picker): emit date in ISO format when events are emitte…
b13f579 
…d and expose an API for same

BREAKING CHANGE: The emitted event's value is now will now be in ISO date string format
@kulkarni-kashyap
fix(date-picker): revert unintended change
797cd88
@kulkarni-kashyap
refactor(date-picker): rename dateFormat to displayFormat
d4cd80c
@kulkarni-kashyap
chore: merge from canary
47e9f4a
@kulkarni-kashyap
docs(date-picker): update docs to accommodate latest changes
aac2277
@kulkarni-kashyap
fix(date-picker): handle input field for range input
0f256a6
@kulkarni-kashyap
refactor(date-picker): make ISO date format mandate for range picker …
1241c7f 
…and related docs changes
@kulkarni-kashyap
fix(date-picker): handle min-date, max-date props to be compatible wi…
51b737f 
…th ISO formats and docs changes
@kulkarni-kashyap
docs(date-picker): format docs
eba5ca2
arvindanta
arvindanta approved these changes Dec 3, 2021
View reviewed changes
Copy link
Collaborator

@arvindanta arvindanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulkarni-kashyap kulkarni-kashyap merged commit f520401 into canary Dec 3, 2021
@kulkarni-kashyap kulkarni-kashyap deleted the feat/date-picker branch December 3, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arvindanta arvindanta arvindanta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulkarni-kashyap @arvindanta