feat(fw-popover): added show/hide event emitters and new prop #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore-kumar-E3682
requested review from
parsuram-vijaysankar and
arvindanta
parsuram-vijaysankar
approved these changes
Nov 12, 2021
| @@ -45,6 +54,18 @@ export class Popover { | |||
| * Whether the popover-content width to be same as that of the popover-trigger. | |||
| */ | |||
| @Prop() sameWidth = true; | |||
| /** | |||
| * Whether the popover-content width to be same as that of the popover-trigger. | |||
There was a problem hiding this comment.
I think the documentation text is wrong!
There was a problem hiding this comment.
I have replaced this prop with the trigger prop, to specify the trigger event on which the popover-content will be shown/hide.
Added trigger prop to specify the trigger type for show/hide the popover-content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(fw-popover): added show/hide event emitters and new prop preventDefault
Checklist:
How Has This Been Tested?