feat: added fw-list-options component and wiring up of fw-popover #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kishore-kumar-E3682
changed the title
renamed methods for fw-option-list and moved hardcoded strings into props.
parsuram-vijaysankar
approved these changes
Nov 2, 2021
|
|
||
| render() { | ||
| return ( | ||
| <ul> |
There was a problem hiding this comment.
Let's change the ul > li to be a pure div based markup as of now!
We should address the markup with the right accessible attributes as part of a follow up PR!
There was a problem hiding this comment.
Sure Parsu, Will add accessible attributes in follow up PR
| } | ||
| } | ||
|
|
||
| renderSelectOption(options: Array<any>) { |
There was a problem hiding this comment.
rename
renderSelectOption > renderSelectOptions
There was a problem hiding this comment.
Thanks for the suggestion i have renamed it.
| /** | ||
| * Placeholder to placed on the search text box. | ||
| */ | ||
| @Prop() searchText = 'Search...'; |
There was a problem hiding this comment.
Let's remove the "..."
There was a problem hiding this comment.
The test Search... is based on the DSM spec.
renamed renderSelectOption to renderSelectOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
How Has This Been Tested?